Enhancement: Upgrade Sparkle XPC framework to support Apple Silicon

p0deje / Maccy

Lightweight clipboard manager for macOS

https://maccy.app

MIT License

13.18k stars 554 forks source link

Enhancement: Upgrade Sparkle XPC framework to support Apple Silicon #288

Closed hguandl closed 3 years ago

hguandl commented 3 years ago

Maccy is quite nice and I use it every day. Recently I switched to an M1 Mac and noticed that the updater Sparkle does not support Apple Silicon.

This can be fixed by upgrading Sparkle. Currently, Sparkle 2.0 only provides nightly builds in GitHub Actions. We can download the artifact and use the new Sparkle.framework and .xpc in XPCServices.

p0deje commented 3 years ago

How did you notice that Sparkle doesn't support M1? I remember upgrading it specifically for this reason - e0ffd033c989ee7f723638fc58a17d4fef10642c.

hguandl commented 3 years ago

I found it in the activity monitor.

Sparkle uses XPC services to become functional in sandboxed app. Therefore the org.sparkle-project.*.xpc in https://github.com/p0deje/Maccy/tree/master/Sparkle should also be upgraded to support Apple Silicon.

p0deje commented 3 years ago

I don't have M1 Mac so I'm not sure how to confirm it's working, but can you please try running this build which includes the latest Sparkle 2.x and XPC services?

Maccy.app.zip

hguandl commented 3 years ago

Yes, activity monitor says they are using Apple architecture now. Thanks!

p0deje commented 3 years ago

Thanks!

AJAYK-01 commented 3 years ago

I don't have M1 Mac so I'm not sure how to confirm it's working, but can you please try running this build which includes the latest Sparkle 2.x and XPC services?

Maccy.app.zip

Thanks for the M1 build mate!

p0deje commented 3 years ago

You don't need to use that build, the latest version support M1 fully.