p0deje / Maccy

Lightweight clipboard manager for macOS
https://maccy.app
MIT License
12.58k stars 532 forks source link

Maccy notifies me every time I copy something #692

Closed vegerot closed 9 months ago

vegerot commented 10 months ago

Before Submitting Your Bug Report

Maccy Version (see 'About' window)

How do I see the about window?

macOS Version

13.6.1

Maccy Settings

{
    "KeyboardShortcuts_delete" = "{\\"carbonModifiers\\":2048,\\"carbonKeyCode\\":51}";
    "KeyboardShortcuts_pin" = "{\\"carbonModifiers\\":2048,\\"carbonKeyCode\\":35}";
    "KeyboardShortcuts_popup" = "{\\"carbonModifiers\\":768,\\"carbonKeyCode\\":34}";
    "LaunchAtLogin__hasMigrated" = 1;
    "NSWindow Frame SUStatusFrame" = "1480 1298 400 134 0 0 3360 1865 ";
    "NSWindow Frame SUUpdateAlert" = "1370 1100 620 398 0 0 3360 1865 ";
    "NSWindow Frame com.sindresorhus.Settings.FrameAutosaveName" = "1409 1112 542 399 0 0 3360 1865 ";
    SUEnableAutomaticChecks = 1;
    SUHasLaunchedBefore = 1;
    SULastCheckTime = "2023-12-06 22:32:00 +0000";
    SUUpdateGroupIdentifier = 1475230968;
    WebKitDefaultFontSize = 13;
    WebKitJavaScriptEnabled = 0;
    WebKitPluginsEnabled = 0;
    WebKitStandardFont = "-apple-system-font";
    WebKitUserStyleSheetEnabledPreferenceKey = 1;
    WebKitUserStyleSheetLocationPreferenceKey = "/Applications/Maccy.app/Contents/Frameworks/Sparkle.framework/Resources/ReleaseNotesColorStyle.css";
    enabledPasteboardTypes =     (
        "public.tiff",
        "public.rtf",
        "public.file-url",
        "public.utf8-plain-text",
        "public.png",
        "public.html"
    );
    historySize = 999;
    ignoredPasteboardTypes =     (
        "com.agilebits.onepassword",
        "com.typeit4me.clipping",
        "Pasteboard generator type",
        "de.petermaurer.TransientPasteboardType",
        "net.antelle.keeweb"
    );
    menuIcon = clipboard;
    migrations =     {
        "2020-04-25-allow-custom-ignored-types" = 1;
        "2020-06-19-use-keyboardshortcuts" = 1;
        "2020-09-01-ignore-keeweb" = 1;
        "2021-02-20-allow-to-customize-supported-types" = 1;
        "2021-06-28-add-title-to-history-item" = 1;
        "2021-10-16-remove-dynamic-pasteboard-types" = 1;
        "2022-08-01-rename-suppress-clear-alert" = 1;
        "2022-11-14-add-html-rtf-to-supported-types" = 1;
        "2023-01-22-add-regexp-search-mode" = 1;
    };
    pasteByDefault = 1;
    searchMode = fuzzy;
    showRecentCopyInMenuBar = 1;
}

Description

For some reason, starting this morning every time I copy something Maccy sends a notification telling me what I just copied

Steps to Reproduce

  1. Copy a thing

Expected: Should not get a notification

Actual: received notification

image
p0deje commented 10 months ago

You can disable notifications for Maccy in System Settings / Notifications.

vegerot commented 10 months ago

Thanks. This seems like a weird default though, right? Why would someone want to be notified whenever they copy something?

p0deje commented 10 months ago

When Maccy starts it asks whether you want to allow notifications or not. If you agree to allow, it would start sending them. If you don't allow or simply close the allow notification - it wouldn't. I guess it's not an ideal behavior, but sort of a default one for most apps.

domoritz commented 9 months ago

I find this behavior confusing as well. Allowing notifications to me just means that an app should be allowed to send any notifications. However, I would expect that I can disable specific kinds of notifications in the app.

tgdn commented 9 months ago

I also find this confusing, and the noise can become quite annoying without an easy way to disable it.

p0deje commented 9 months ago

Would you it be okay to have a button in Maccy Preferences that takes you to System Settings / Notifications / Maccy where you can configure it all?

cotwitch commented 9 months ago

Dear Alex, in my opinion, there should be a preference option to choose if copied content should be "sent to notifications" or not.

What if you (as a developer) will need (in a future) to notify users about something really important (like a new version of the application or similar) and lot (maybe most?) of users will have notifications disabled?

Notifications settings in macOS are "global" (so, it disables ALL the Maccy notifications).

But me, as an happy user 🥳 of Maccy - I don't want to disable ALL the Maccy notifications - as I'm still curious 👀 about any other, meaningful notifications from Maccy... I just want to disable (solely) showing annoying notification when anything is copied into the clipboard.

Kindly thank you for consideration 🎩

vegerot commented 9 months ago

silly question, but why is this even a feature? Why would one of your users want to be notified every time they copy something?

p0deje commented 9 months ago

Asked in #211

p0deje commented 9 months ago

To be frank, the current implementation doesn't fully utilize a notification center. For example, sounds are played as plain sounds because I've received multiple bug reports saying that custom sounds are not used and system beep is used instead. Hence, sounds don't respect DND for example. This needs to be fixed.

I agree it would be best to implement a configuration for each notification type, yet I don't know how useful it would be compared to the effort of developing it (and notably translating to all the different languages Maccy supports). IMO it's too much work for little value.

I will add a button "Configure Notifications" in Maccy preferences that takes you to System Settings for now. I will also consider implementing more advanced configurations for each notification type if Maccy adds more notifications at some point.

domoritz commented 9 months ago

What was the original motivation for having notifications for copied items? Maybe it should be off by default until someone presses the "configure notifications" button?

cotwitch commented 9 months ago

By the way, for example, Fluor application, which I'm also using uses following configuration/preferences:

Screenshot 2023-12-29 at 01 55 58
p0deje commented 9 months ago

In the upcoming version, there will be a link to notifications/sounds configuration in the bottom of General preferences:

Screenshot 2023-12-28 at 19 01 37

I'm going to close this for now, see https://github.com/p0deje/Maccy/issues/692#issuecomment-1871424363 for an explanation. It doesn't seem to be possible to disable sounds in DND, let's see if Apple improves custom sounds in notifications in the future so we could just use it instead.

findepi commented 9 months ago

When Maccy starts it asks whether you want to allow notifications or not. If you agree to allow, it would start sending them.

just sharing my user perspective. Some future Maccy version might have a notification e.g for "new release with bug fixes available". I may want to get it, but I won't if i disable all notifications in the notifications center. As an engaged user would prefer fine-grained controls within the app. I disable notifications in Mac's notifications center only if an app annoys me :)

anyway, thanks for Maccy and maintaining it! it's awesome!

domoritz commented 9 months ago

That's well put and describes why I originally came here to report a bug. Disabling notifications is a way for me to defend against applications that notify too much. It feels like a last resort rather than a setting.

marcelarie commented 8 months ago

The notifications should be enabled by default to allow the app to notify users about important things like new updates or errors, but not on every copy.

jimmyhmiller commented 6 months ago

I just spent an hour trying to debug where this sound was coming from. I had turned maacy notifications to None, rather than turning them off. I could not correlate as I as working that it was copying things that was making this really annoying noise.

I maybe would have found this if the sound setting had been in maacy itself, rather than a side-effect of notifications being enabled. It also seems weird that the sound would play when it is so to none.

Do people actually want these noises?

p0deje commented 6 months ago

It also seems weird that the sound would play when it is so to none.

I think that's allowed - you can hide visual alerts but keep sounds.

I maybe would have found this if the sound setting had been in maacy itself, rather than a side-effect of notifications being enabled.

The link in Maccy general preferences is called "Notifications & sounds".

Screenshot 2024-03-18 at 12 22 01

sigh I guess I need to implement a separate settings pane, but it's too much at the moment for me.

jimmyhmiller commented 6 months ago

@p0deje I totally get it from your perspective. It is possible to change these settings. If this were some chat app I would have been able to figure it out. But I copy and paste a lot. It is just like typing to me. I just never would have guessed that a clipboard manager would play sounds as "notifications" in response to my actions. Notifications are something I think of as happening separate from my own actions, a result of something happening in the background, or someone sending me a message.

p0deje commented 6 months ago

@jimmyhmiller I understand and that's exactly how I use notifications too. Yet, playing sounds on copy/paste is something that was requested by users (#91) so there are some cases when people would want that.

jimmyhmiller commented 6 months ago

@p0deje No worries, I get that people want different things. Thanks for the great piece of software.