search

p0deje / Maccy

Lightweight clipboard manager for macOS
https://maccy.app
MIT License
11.84k stars 510 forks source link

Search string visibility 2 #728

Closed gongchoong closed 7 months ago

gongchoong commented 7 months ago

@p0deje App crashes when you open Preferences - Appearance. Could you guide me how to fix the xib file error in AppearanceSettingsViewController.xib?

p0deje commented 7 months ago

@gongchoong I think the XIB is outdated, I see that you changed all the text fields back to sliders (https://github.com/p0deje/Maccy/pull/728/files#diff-4802f8bfa12187d4de5899afa761392c9f721446c23558dec3164971eb547992R164), which is few versions old. I would recommend you to review the diff to revert unrelated changes in XIB file. Otherwise, you can just revert it completely and -re-add NSPopUpButton again, then re-bind it to controller

p0deje commented 7 months ago

If you don't mind, I'll do some minor cleanup and merge it as a single commit.

p0deje commented 7 months ago

Actually, doesn't matter, I can just merge it as-is and fix it afterward. Thank you for contributing!