test Initial translation (arabic-العربية)

p0deje / Maccy

Lightweight clipboard manager for macOS

https://maccy.app

MIT License

12.49k stars 531 forks source link

test Initial translation (arabic-العربية) #766

Closed columbusux closed 5 months ago

columbusux commented 5 months ago

pls test i haven't slept for two days...

p0deje commented 5 months ago

pls test i haven't slept for two days...

Thank you, I'll test. You better get some sleep 😴

p0deje commented 5 months ago

Looking through PR, I would ask you to revert the conversion to Maccy/Localizable.xcstrings. It's a format that Xcode recommends, but it's not supported by the BartyCrouch tool that is used, so I'm holding off from this migration.

I can undo the change myself with some Vim macros though.

p0deje commented 5 months ago

Thank you for the PR, please see my review below!

Main window

Everything is translated except for the "Preview" popup. Can you add translations to Maccy/Menu/Preview/ar.lproj/Preview.strings?

General preferences

Everything is great with a small exception to the layout of hotkeys controls. I'll fix that myself, you don't have to do anything.

Appearance preferences

There are some missing translations, can you add them to Maccy/Settings/ar.lproj/AppearanceSettingsViewController.strings?

Others

The rest looks great, please see some screenshots:

columbusux commented 5 months ago

Thank you for the review, and I apologize. I think I made some mistakes unintentionally. I wasn’t fully focused at the time. Don’t worry, I will do that after I’m free. 🫡 Thanks again brother.

MohammedEssehemy commented 5 months ago

Thank you @columbusux for adding the Arabic translation 🙏🏻

p0deje commented 5 months ago

Looks great, I'm ready to merge it if you consider it complete.

columbusux commented 5 months ago

Yes, you good to go. It was an honor for me to help and work with you. I wish you success brother. ♥️

p0deje commented 5 months ago

Thank you once again, all the best to you too!