p0deje / Maccy

Lightweight clipboard manager for macOS
https://maccy.app
MIT License
13.11k stars 551 forks source link

cmd+[ to dismiss maccy same as ctrl+[ #768

Closed tmpm697 closed 7 months ago

tmpm697 commented 7 months ago

Before Submitting Your Feature Request

Problem

I use both ctrl+[ and more often cmd+[ to dismiss stuffs around (IDEs, terminals)

So it'll nice if we can add more option to use cmd+[ works same as ctrl+[

ty.

Solution

No response

p0deje commented 7 months ago

That's the first time I've heard about these shortcuts. Can you tell me what those are doing?

tmpm697 commented 7 months ago

idk what is default ctrl+[ on macos, but ctrl+[ is default to escape if u use (neo)vim.

I use maccy with default settings, ctrl-c or ctrl+[ has same effect (dismiss/abort maccy) -- probably they're escape keys.

In my case I also use left cmd a lot, and sometime it's quicker to use cmd+[ than ctrl+[

tmpm697 commented 7 months ago

it seems also default that i can use ctrl+n/p to navigate up/down entries, but it's ideal if we can re-map this to like cmd+n/p or opt+n/p

p0deje commented 7 months ago

ctrl+n/p are standard mappings for macOS menus so you can use them in Maccy as well. ctrl+[ has no effect on my Maccy, I wonder how it's being closed. I'll see what is the best way to allow changing the shortucts.

tmpm697 commented 7 months ago

ctrl+[ has no effect on my Maccy, I wonder how it's being closed.

that's werid, so how normally u dismiss maccy floating window?

and yes, i use cmd mainly and totally get rid of ctrl in my workflow, so trigger maccy and reaching ctrl break it.

p0deje commented 7 months ago

that's werid, so how normally u dismiss maccy floating window?

I press Escape, or press the popup shortcut again (default CMD+SHIFT+C)

tmpm697 commented 7 months ago

Screenshot 2024-04-24 at 12 41 18 PM

weirdly, i tried cmd+shift+c, does not work for me, probably i changed some settings idk. it's macos ventura 13.6.6 and Maccy 0.30.0

p0deje commented 7 months ago

The shortcut to close is the same as to open. In your case, it's COMMAND+D.

tmpm697 commented 7 months ago

The shortcut to close is the same as to open. In your case, it's COMMAND+D.

oh that's nice, but if i can keep holding cmd and use cmd+n/p to navigate up/down the list is ideal. ty.

p0deje commented 7 months ago

@tmpm697 Unfortunately, this means potential conflicts with pinned items using n/p letters. Also, this would not be consistent with the rest of macOS applications.

tmpm697 commented 7 months ago

@tmpm697 Unfortunately, this means potential conflicts with pinned items using n/p letters. Also, this would not be consistent with the rest of macOS applications.

currently u can change pinned item via opt+p which is not cmd+p.

but what i want in sump up is:

cmd+d to open maccy
cmd+n to down entries
cmd+p to up entries
cmd+[ to close/dismiss maccy

conflicts can be solved from users settings but i think, can it be supported?

u don't need to make it default like about, but allow users to change to it.

p0deje commented 7 months ago

currently u can change pinned item via opt+p which is not cmd+p.

users can change pinned item key via settings -

Screenshot 2024-04-24 at 09 41 14

P is already forbidden, but N is still allowed

tmpm697 commented 7 months ago

Screenshot 2024-04-25 at 12 52 44 AM

why my list is empty like above image? i think the keybinding implementation is due to each app? double click does not take any effect (expect to create new entry)

like in vscode, i can map cmd+n/p to whatever i want while i'm in that app.

p0deje commented 7 months ago

why my list is empty like above image? i think the keybinding implementation is due to each app? double click does not take any effect (expect to create new entry)

You need to first pin something using OPTION+P.

like in vscode, i can map cmd+n/p to whatever i want while i'm in that app.

Yes, but CMD+N is reserved for pins. I understand your use case, but I don't see myself implementing this. There is quite a lot to do to allow customization of such shortcuts, translate into all languages that Maccy supports and somehow deal with conflicts of pins. Sorry, but I don't think Maccy should allow to change every single keybinding it supports.

You are still welcome to send PRs implementing this or feel free to fork it and replace the keybindings.

tmpm697 commented 7 months ago

I don't mind if it's cmd+j/k, in fact i use cmd+j/k to navigate suffs more than cmd+n/p,

idk why need translate into all languages but this can be just for us/uk keyboard layouts?

p0deje commented 7 months ago

I don't mind if it's cmd+j/k, in fact i use cmd+j/k to navigate suffs more than cmd+n/p,

Again, those would conflict with pinned letters.

idk why need translate into all languages but this can be just for us/uk keyboard layouts?

The settings page to change this keys would need to be translated to all languages.