search

p0ody / ff2ebook

WIP.
http://www.ff2ebook.com
18 stars 2 forks source link

Critical errors Not finding multiple chapters #17

Closed PhoenixFireOwl closed 5 years ago

PhoenixFireOwl commented 5 years ago

Still not able to download any ebooks on old, current or new sites. Critical errors, can't find chapter. Similar to issue #9. Even get error about can't find title name on newer version.

So far, all FF.net links not working for me.

Here's part of this issue's Critcal errors for https://www.fanfiction.net/s/12144422/83/The-Intelligent-Potter

Collecting Fiction infos... Collecting chapters data... Received chapter #1 data. Critical Error: Couldn't find chapter(2) text. Critical Error: Couldn't find chapter(3) text. Received chapter #4 data. Critical Error: Couldn't find chapter(6) text. Critical Error: Couldn't find chapter(5) text. Received chapter #7 data. Received chapter #8 data. Received chapter #9 data. Critical Error: Couldn't find chapter(10) text. Critical Error: Couldn't find chapter(11) text. Received chapter #12 data. Critical Error: Couldn't find chapter(13) text. Received chapter #14 data. Critical Error: Couldn't find chapter(15) text.

Can you help me? I even used different browsers. Thanks.

StarWolf3000 commented 5 years ago

No need to open multiple similar issues.

@p0ody FF seems to have updated the HTML source for chapters, so it may take a while to get updated.

The script looks for:

<div style='padding:5px 10px 5px 10px;' class='storycontent nocopy' id='storycontent' >chapter content</div>

while the recent HTML source is

<div role='main' aria-label='story content' class='storytextp' id='storytextp'  align=center style='padding:0 0.5em 0 0.5em;'>
<div class='storytext xcontrast_txt nocopy' id='storytext'>chapter content</div>
</div>
StarWolf3000 commented 5 years ago

Submitted a PR to address this issue: #18

p0ody commented 5 years ago

The preg_match was fine, it uses the mobile version of ff.net so thats why its not the same as what you found in the source.

You were right for the encoding though, thank for your help @StarWolf3000

StarWolf3000 commented 5 years ago

I know this might be too much to ask, but could you enable the GZip support on the /old downloader too? I still prefer the epubs from that one over the newer one. If not, then I will use the new one.

p0ody commented 5 years ago

Have you tried it? I changed it at the same time and it worked when I tried it earlier. Only the node version is currently not working Afaik

On Fri., Jun. 21, 2019, 12:33 StarWolf3000, notifications@github.com wrote:

I know this might be too much to ask, but could you enable the GZip support on the /old downloader too? I still prefer the epubs from that one over the newer one. If not, then I will use the new one.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/p0ody/ff2ebook/issues/17?email_source=notifications&email_token=AAEJWQH6VQN6RIZDGM756ADP3T7FRA5CNFSM4HZQIG2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYI6JPQ#issuecomment-504489150, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEJWQFAHBMTPS64DXI6BGLP3T7FRANCNFSM4HZQIG2A .

StarWolf3000 commented 5 years ago

I tried it indeed a few minutes ago, and it worked, so nothing to do there :)