p0ody / ff2ebook

WIP.
http://www.ff2ebook.com
18 stars 2 forks source link

Chapters instead of characters #50

Closed kolbdog3333 closed 2 years ago

kolbdog3333 commented 2 years ago

Can you fix it so if there are no characters in the fanfic it remains blank instead of number of chapters

p0ody commented 2 years ago

Could you provide an example please (Fic id or link) Thanks

kolbdog3333 commented 2 years ago

Whenever there are no characters in a chapter in the heading like this one https://www.fanfiction.net/s/12605611/1/The-Lion-Guard-My-Version It shows the number of chapters instead of blank

p0ody commented 2 years ago

To get it fixed, i removed the pairing lookup because there is too many combination of fic "header" to match properly every time and get the result we want:

example:

  1. Rated: [Fiction K+] - Spanish - Narcissa M., Druella B. - Words: 315 - // No story type, pairing. no chapter count
  2. Rated: [Fiction K+] - English - Hurt/Comfort/Friendship - Chapters: 200 - Words: 317,152 - // Story type, no pairing, chapter count
  3. Rated: [Fiction T] - English - Words: 551 - // No story type, no pairing, no chapter count
  4. Rated: [Fiction T] - English - Drama/Romance - Harry P., Voldemort, Tom R. Jr., Gellert G. - Chapters: 14 - Words: 179,019 - // Story type, pairing, chapter count

And the only thing that separate each data is only "-" with no way knowing what is supposed to be between the -.

So its pretty hard to get the wanted value.

Edit: I might add a new row in the title page instead of pairing and Fic type that will use the value between the language and the Chapter count/Words count.

Something like this using the example above:

  1. Narcissa M., Druella B.
  2. Hurt/Comfort/Friendship
  3. blank
  4. Drama/Romance - Harry P., Voldemort, Tom R. Jr., Gellert G.

a new row called something like "Additional information"

i think that would be a decent compromise.