p0p4k / pflowtts_pytorch

Unofficial implementation of NVIDIA P-Flow TTS paper
https://neurips.cc/virtual/2023/poster/69899
MIT License
198 stars 28 forks source link

possible custom model inference issue #6

Open kunibald413 opened 7 months ago

kunibald413 commented 7 months ago
  if not hasattr(args, "checkpoint_path") and args.checkpoint_path is None:
      model_path = args.checkpoint_path

shouldn't this be a positive check?

  if hasattr(args, "checkpoint_path") and args.checkpoint_path:
      model_path = args.checkpoint_path

https://github.com/p0p4k/pflowtts_pytorch/blob/82c70bf71e082356c785fcdd8fc24eea912abfc4/pflow/cli.py#L68C17-L68C17

p0p4k commented 7 months ago

oops. Nice catch! (it is a byproduct of me blindly using this)