search

p0p4k / pflowtts_pytorch

Unofficial implementation of NVIDIA P-Flow TTS paper
https://neurips.cc/virtual/2023/poster/69899
MIT License
198 stars 28 forks source link

_clean_text is returning invalid symbol #9

Open eschmidbauer opened 7 months ago

eschmidbauer commented 7 months ago

Hi, thanks for sharing this project! I noticed a small issue when running: python generate_data_statistics.py -i conf.yaml Im getting an undefined symbol exception error. When i added debug info, i found that the function _clean_text() is inserting Unicode Decimal Code ̃ I checked my dataset, and Unicode Decimal Code ̃ is not in the dataset anywhere I added these lines to confirm the issue was coming from clean_text = _clean_text(text, cleaner_names) image

Any help would be appreciated, thanks!

zidsi commented 7 months ago

Depending on defined cleaners in your conf.yaml phonemizer might bi inserting combining tilde to text converted from characters to phonemes.

p0p4k commented 7 months ago

Also, I am debating whether normalizing the mel-spec is even necessary for this project.

eschmidbauer commented 7 months ago

Can you advise how to use a different text phonemizer?

p0p4k commented 7 months ago

Different as in, what is your use case?

eschmidbauer commented 7 months ago

Depending on defined cleaners in your conf.yaml phonemizer might bi inserting combining tilde to text converted from characters to phonemes.

Im curious how to define a different cleaner in the config

p0p4k commented 7 months ago

This file has all the info about adding new cleaners https://github.com/p0p4k/pflowtts_pytorch/blob/master/pflow/text/cleaners.py You can get some inspiration from https://github.com/p0p4k/CoquiTTS/tree/dev/TTS/tts/utils/text to modify depending on your use case. Also, the tilde character thing, you can just continue and drop it, might not be a big issue.