search

p0p4k / vits2_pytorch

unofficial vits2-TTS implementation in pytorch
https://arxiv.org/abs/2307.16430
MIT License
465 stars 81 forks source link

fix: pep8 and new librosa #31

Closed shigabeev closed 10 months ago

shigabeev commented 10 months ago

Hello!

The existing versions of Numpy and Librosa in the repository are outdated, leading to installation challenges. I've updated the mel extraction function to ensure compatibility with the newer versions of Librosa. Additionally, I've bumped the versions of both Numpy and Scipy.

The specific change can be found in mel_processing.py

Previously, the code was:

mel = librosa_mel_fn(sampling_rate, n_fft, num_mels, fmin, fmax)

I've modified it to:

mel = librosa_mel_fn(sr=sampling_rate, n_fft=n_fft, n_mels=num_mels, fmin=fmin, fmax=fmax)

Moreover, I've run autopep8 on all .py files to ensure consistent indentation throughout the codebase.

Thanks for considering my changes!

p0p4k commented 10 months ago

HI can you re-do this PR with latest patch? Thanks.

shigabeev commented 10 months ago

Sure. Later today

shigabeev commented 10 months ago

Done

shigabeev commented 10 months ago

I guess PEP8 should be done by you. Check the newest PR