p0p4k / vits2_pytorch

unofficial vits2-TTS implementation in pytorch
https://arxiv.org/abs/2307.16430
MIT License
465 stars 81 forks source link

Checkpoint saves? #58

Closed ziyaad30 closed 9 months ago

ziyaad30 commented 9 months ago

Should we not save the iteration/global_step here:

https://github.com/p0p4k/vits2_pytorch/blob/4cc093ecafff9b0a92c5da91a9a09ee7fe320082/train.py#L498

instead of the epoch?

Edit:

As well as: https://github.com/p0p4k/vits2_pytorch/blob/4cc093ecafff9b0a92c5da91a9a09ee7fe320082/train.py#L231 Should the scheduler not step per iteration/global_step.

I am very very new to this, just asking as I did some reading online. Thanx

p0p4k commented 9 months ago

Depends on your needs. Can just move the save snippet where ever you need in the training script.