sieve_rule translate update

p0pr0ck5 / lua-resty-waf

High-performance WAF built on the OpenResty stack

GNU General Public License v3.0

1.28k stars 305 forks source link

sieve_rule translate update #289

Closed DrakaGytis closed 6 years ago

DrakaGytis commented 7 years ago

fixed crash, while no valid rule to sieve from was given in sieve_rule.
fixed sieve of a rule, when parameters are mistranslated while checking only the type and not also parse of the translation.

p0pr0ck5 commented 7 years ago

Thanks @DrakaGytis! Would it be possible to have either some comments or a more clear/descriptive commit message explaining this change? I would also say let's have some tests, but I don't think we have unit tests for this public method, so not a blocker here. I can work on this later.

p0pr0ck5 commented 7 years ago

Also, any chance you can rebase (not back-merge, but rebase) your branch?

DrakaGytis commented 7 years ago

Yes, give me some time to fix this.

p0pr0ck5 commented 6 years ago

Closing as stale. May revisit this in the future.