search

p0w3rsh3ll / AdobeGPOTemplates

Other
11 stars 3 forks source link

Supported Versions #2

Open flatlinebb opened 5 years ago

flatlinebb commented 5 years ago

Are any other versions of Adobe Acrobat products supported, other than DC, 2017 and 2015? I have some versions XI and v9 at a client, but the script did not recognize them as valid versions when creating templates.

And also, thank you for an awesome script! Saved me hours of manual labor. Now we're rocking GPO's for the Security settings.

p0w3rsh3ll commented 5 years ago

Hi, Thanks for your feedback. XI and 9 have reached end-of-life as far as I know: https://theblog.adobe.com/adobe-acrobat-xi-and-adobe-reader-xi-end-of-support/ That's why the code doesn't recognize these previous versions.

I've started to test to modify the function to use XI and 9.0 versions. See this commit 5d12b221b5170dc1f544e7644159df51e7154afb in the dev branch. But it currently produces some errors when you import the admx, adml files. It requires more modifications.

p0w3rsh3ll commented 5 years ago

@flatlinebb Ok, this commit af323518d8385a4208ad18f035eb8c40d0e4d454 will add 9.0,10.0 and 11.0 versions. It will allow you to have the same settings although they may be irrelevant in these older versions.

p0w3rsh3ll commented 5 years ago

@flatlinebb Can you please test it and tell me if it works for you?

flatlinebb commented 5 years ago

How do I test the new commit? I downloaded the new updated AdobeGPOTemplates.psm1 file and replaced the current one. Then I tried running

New-AdobeGPOTemplate -Product Reader,Acrobat -Version 2017,2015,DC,11.0,10.0,9.0

But I keep getting an error:

New-AdobeGPOTemplate : Cannot validate argument on parameter 'Version'. The argument "11" does not belong to the set "2017,2015,DC,11.0,10.0,9.0" specified by the ValidateSet
attribute. Supply an argument that is in the set and then try the command again.
At line:1 char:55
+ ... OTemplate -Product Reader,Acrobat -Version 2017,2015,DC,11.0,10.0,9.0
+                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [New-AdobeGPOTemplate], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationError,New-AdobeGPOTemplate
p0w3rsh3ll commented 5 years ago

Powershell will treat 11.0 as int, you need to force it to treat it as a string because the version parameter expects a string

New-AdobeGPOTemplate -Product Reader,Acrobat -Version 2017,2015,DC,'11.0','10.0','9.0'
flatlinebb commented 5 years ago

That worked! I should have known better. Maybe it can be added to the documentation for the syntax. It worked as far as generating new templates and Group Policy recognizing them and allowing me to change the Security options. Whether the end-points will actually respect that setting, we will see. It's not something I can test ad-hoc.

Thank you for your quick response and prompt changes. I really appreciate your script making me look good to my boss :)

On Tue, Apr 9, 2019 at 11:58 AM p0w3rsh3ll notifications@github.com wrote:

Powershell will treat 11.0 as int, you need to force it to treat it as a string because the version parameter expects a string

New-AdobeGPOTemplate -Product Reader,Acrobat -Version 2017,2015,DC,'11.0','10.0','9.0'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/p0w3rsh3ll/AdobeGPOTemplates/issues/2#issuecomment-481392098, or mute the thread https://github.com/notifications/unsubscribe-auth/AEjHKlA6u0b5QD8-R_3qSzTIn9FDCk8jks5vfOLygaJpZM4cd2sT .