search

p11-glue / p11-kit

Provides a way to load and enumerate PKCS#11 modules.
https://p11-glue.github.io/p11-glue/p11-kit.html
Other
150 stars 92 forks source link

p11-kit commands: Add --login option #587

Closed ueno closed 11 months ago

ueno commented 11 months ago

Previously, those tools determined whether a login is necessary by checking the presence of "pin-value" query attribute in the URI. It was too implicit and against modern security practice. This instead asks users to specify --login option and if no "pin-value" is given, it tries to read a PIN from the terminal.

Fixes: #570

coveralls commented 11 months ago

Coverage Status

coverage: 69.342% (-0.1%) from 69.476% when pulling 812cab2bf69f15f59f835ec449dd8ea9025e3903 on ueno:wip/dueno/login into 605232952fa4b4b9f0d7ac8d79afa97f992136a5 on p11-glue:master.

ZoltanFridrich commented 11 months ago

does this also resolve #564?