Closed ametzler closed 8 months ago
Thank you; I see no problem in merging this. One nit: the second commit has an ill-formatted log message "use_libbsd-overlay on GNU/hurd and kfreebsd."; maybe the first "_" should be replaced with a space?
Btw, is Meson available and supposed to work on GNU/Hurd?
ueno wrote
Thank you; I see no problem in merging this. One nit: the second commit has an ill-formatted log message "use_libbsd-overlay on GNU/hurd and kfreebsd."; maybe the first "_" should be replaced with a space?
I have force-pushed this change.
Btw, is Meson available and supposed to work on GNU/Hurd?
Yes, it should work. I played a little bit but this seems to need somebody familiar with meson. I did not get beyond
if ['gnu', 'gnu/kfreebsd'].contains(host_system)
libbsd_overlay = dependency('libbsd-overlay')
endif
and adding this to dependencies: of some targets. Which is not enough. This test
foreach h : headers
if cc.has_header(h)
conf.set('HAVE_' + h.underscorify().to_upper(), 1)
endif
endforeach
would also need to use libbsd-overlay's CFLAGS to find its ucred.h
Afaik has_header
also takes dependencies
so you can write something like:
foreach h : headers
if cc.has_header(h, dependencies: libbsd_overlay)
conf.set('HAVE_' + h.underscorify().to_upper(), 1)
endif
endforeach
Afaik
has_header
also takesdependencies
so you can write something like:foreach h : headers if cc.has_header(h, dependencies: libbsd_overlay) conf.set('HAVE_' + h.underscorify().to_upper(), 1) endif endforeach
Thanks, I have used this and pushed an updated version that also changes the meson build.
Hello,
we have been patching p11-kit on Debian for GNU/Hurd and kfreebsd compatibility for a long time. Find attached the latest iteration of the (small) patchset. kfreebsd-compatibilty is untested nowadays since we have dropped the port on Debian. - Please tell me if I should drop the respective code ("kfreebsd*-gnu |")
cu Andreas