search

p11-glue / p11-kit

Provides a way to load and enumerate PKCS#11 modules.
https://p11-glue.github.io/p11-glue/p11-kit.html
Other
151 stars 95 forks source link

iter: Fix recursive attribute loading #642

Closed heftig closed 4 months ago

heftig commented 4 months ago

Fixes: https://github.com/p11-glue/p11-kit/issues/641

coveralls commented 4 months ago

Coverage Status

coverage: 69.54% (+0.003%) from 69.537% when pulling ce2e51639726bfc1691113c2f7fdc481dad2d66a on heftig:recursive-fix into d9449ee55be7adf4666720dd7c1957b44960159b on p11-glue:master.

ZoltanFridrich commented 4 months ago

Thank you for the MR. I will test it on fedora before merging.

ZoltanFridrich commented 4 months ago

Looking at the code I cannot figure out why I chose to check the attr instead of templ + i. Seems like a mistake, however its weird that it didn't fail on x86_64 as well. I can confirm that the patch fixed the issue. Thank you!

coveralls commented 4 months ago

Coverage Status

coverage: 69.533% (-0.03%) from 69.562% when pulling 714b9e700a037028c5612fc99bfc80756f18bfe2 on heftig:recursive-fix into 694d5cbc89541090664dfb5a43123c123f63b80d on p11-glue:master.