search

p11-glue / p11-kit

Provides a way to load and enumerate PKCS#11 modules.
https://p11-glue.github.io/p11-glue/p11-kit.html
Other
151 stars 94 forks source link

p11-kit: Move CRYPTOKI_GNU definitions to <p11-kit/p11-kit.h> #653

Closed ueno closed 2 months ago

ueno commented 2 months ago

Previously, the same fallback types are defined in <p11-kit/uri.h> and <p11-kit/iter.h> if CRYPTOKI_GNU is defined. This moves those to <p11-kit/p11-kit.h> so they are not redefined.

Fixes: #649

coveralls commented 2 months ago

Coverage Status

coverage: 69.533%. remained the same when pulling 692a09a3ed01d5b2ab2c0ba29f42e53a066d8ba6 on ueno:wip/dueno/compat-simple into 078acddf9185569cab23257cadae86432d2834f4 on p11-glue:master.

ueno commented 2 months ago

I can't verify whether it works, but it looks good.

Me neither, but with CFLAGS="-std=gnu99 -pedantic", the warning is gone.

ueno commented 2 months ago

Thanks for the review!