possible comma misuse warning in shuffle2x2.h

p12tic / libsimdpp

Portable header-only C++ low level SIMD library

Boost Software License 1.0

1.24k stars 129 forks source link

Open peabody-korg opened 4 years ago

peabody-korg commented 4 years ago

xcode SSE build, dev branch at dcc04d11

Possible misuse of comma operator here:

line 277: float32<4> fa, fb; fa = a, fb = b;

line 282: float32<4> fa, fb; fa = a, fb = b;

guessing both of these should probably be semicolons instead.

abique commented 4 years ago

I think so too. This coding style is dodgy ;-)

Maybe you can provide a pull request?