p1usminus / roomybookmarksredux

Roomy Bookmarks Toolbar for Waterfox/Firefox
6 stars 1 forks source link

overpage/multirow: bookmark items look different after disabling multirow #25

Closed p1usminus closed 1 year ago

p1usminus commented 1 year ago

This one is really minor but I may come back to it when the other issues are closed.

When using the multirow and display over page options, if multirow is disabled the alignment of the bookmark items gets messed up - it's like the toolbar is the wrong height and the icons move like they are buttons (and are smaller.)

Before: Screenshot from 2023-01-04 04-07-57

After: Screenshot from 2023-01-04 04-09-38

After, mouseover Screenshot from 2023-01-04 04-09-56

I initially thought it could be related to overPage.css, but given the behaviour shown here, it may be related to the way the multirow feature is disabled in overlay.js. Maybe it needs a ResizeObserver due to the (potential) height change of the bookmarks bar?

p1usminus commented 1 year ago

Okay so it looks like this only affects folders, weird.

Increasing the top/bottom margin (under 'Labels settings') cuts off more of the text and makes the folder icon smaller.

Screenshot from 2023-01-04 05-06-04

117649 commented 1 year ago

Okay so it looks like this only affects folders, weird.

Increasing the top/bottom margin (under 'Labels settings') cuts off more of the text and makes the folder icon smaller.

Screenshot from 2023-01-04 05-06-04

It's very understandable that folder have whole set of different padding/margin rules.

p1usminus commented 1 year ago

This is actually really annoying me!

Computed rules have not given me anything useful.

It looks like the folder icon height is calculated from the toolbar height - (top margin + bottom margin), instead of the toolbar height being calculated from icon height + (top margin + bottom margin)

And I am not sure what happened to the toolbarbutton-text, perhaps the wrong display type.

p1usminus commented 1 year ago

This was simply a padding conflict: https://old.reddit.com/r/FirefoxCSS/comments/10gtj8g/help_please_the_bookmark_bar_gets_worse_every/j56d1yv/