search

p2-inc / idp-wizard

Identity Provider setup wizards for Keycloak
https://phasetwo.io
Other
1 stars 1 forks source link

The whole metadata response is getting added, not just the relevant data #116

Closed xgp closed 1 year ago

xgp commented 1 year ago

It looks like the whole metadata fetch response is getting added, not just the data element. Not sure when this changed, but it appears to be effecting all SAML clients.

{
  "alias": "awssso-saml-UUSLfBuJGclD9bcx",
  "displayName": "AWS SSO Saml",
  "providerId": "saml",
  "config": {
    "syncMode": "IMPORT",
    "allowCreate": "true",
    "nameIDPolicyFormat": "urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified",
    "principalType": "SUBJECT",
    "data": {
      "validateSignature": "false",
      "signingCertificate": "MIIDAzCCAeugAwIBAgIBATANBgkqhkiG9w0BAQsFADBFMRYwFAYDVQQDDA1hbWF6b25hd3MuY29tMQ0wCwYDVQQLDARJREFTMQ8wDQYDVQQKDAZBbWF6b24xCzAJBgNVBAYTAlVTMB4XDTIyMTAwODExMjU0MFoXDTI3MTAwODExMjU0MFowRTEWMBQGA1UEAwwNYW1hem9uYXdzLmNvbTENMAsGA1UECwwESURBUzEPMA0GA1UECgwGQW1hem9uMQswCQYDVQQGEwJVUzCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALT5X4aK2VUgcs2XTFsQRsp9KCVwnLnLZbz5YQZEQuC4WyzBve2//8SCXYXKy3htYOyKU+l710yXoKgZB42ADNwWjgCHq4e1sMozY1yGVPF3dYYzty/sMJ+ErtxUZDeC6x7L2MeQyWTjOZpTsDpm/DuBBllknhT0OLjI5K2cLux92QZdZOI+Z8b0YAIeVsRjiy3DK6RU6jwgmLmFLpnTE2U0SSI68lIl7CrK8fumYt43dkP7n8+/eoQGRp7VO9MGbx+3aGp1xUOZxVpPPQBYvV788Yk8AUhYzj+AAZABpaUe8irgoAPdJ07ZS/T0zjPW/U3k8eB7XUZ+cgIgz8WT42sCAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAVaQkwIw9q9JKGyDN9nSWD01xUf5pL8Hxysu3bKWVMTwCPs9n4Okk4F0oL3884Fu2WGGXZ3Um3X4MWmk4C2s2cBQwVyU4jue85qdIA4dPCorO+cfkSAB5JWQ45jfT2GtDo0XHorqSRfCyNGvhOlJ9oC+uw1nkEnufEht9PI+ph83wIGNEbDonVm6N0vCuuhbFMkUMOi+frrLMS43VNCA4/6qj0erB3SI4LF2ph6ny6Y5vQqjHjSkgfgFV8ZHor6eevFP1NEjdsowexF0fXllrJSDKwbavrIb1c5U4Fl6xWzLGUJzh5YxxSCKflYuRl9or4GSNL4mgXt+gqko1FDELBQ==",
      "postBindingLogout": "true",
      "singleLogoutServiceUrl": "https://portal.sso.us-west-2.amazonaws.com/saml/logout/NzczNTMyNjQwNjM2X2lucy0yMDk3ZjdiYmM3NzVjMDg0",
      "postBindingResponse": "true",
      "nameIDPolicyFormat": "",
      "idpEntityId": "https://portal.sso.us-west-2.amazonaws.com/saml/assertion/NzczNTMyNjQwNjM2X2lucy0yMDk3ZjdiYmM3NzVjMDg0",
      "loginHint": "false",
      "enabledFromMetadata": "true",
      "postBindingAuthnRequest": "true",
      "singleSignOnServiceUrl": "https://portal.sso.us-west-2.amazonaws.com/saml/assertion/NzczNTMyNjQwNjM2X2lucy0yMDk3ZjdiYmM3NzVjMDg0",
      "wantAuthnRequestsSigned": "false",
      "addExtensionsElementWithKeyInfo": "false"
    },
    "status": 200,
    "statusText": "",
    "headers": {
      "content-encoding": "gzip",
      "content-type": "application/json",
      "date": "Sat, 08 Oct 2022 11:26:39 GMT",
      "referrer-policy": "no-referrer",
      "strict-transport-security": "max-age=31536000; includeSubDomains",
      "vary": "Accept-Encoding",
      "via": "1.1 e0720e45d2e7ea5da3d185114a45e51e.cloudfront.net (CloudFront)",
      "x-amz-cf-id": "Ijbg4vmIsrYCVPVJ_ES8c93H-onPTgQjBFLcMoNELqMd49Xvc5iNrA==",
      "x-amz-cf-pop": "CDG52-P2",
      "x-cache": "Miss from cloudfront",
      "x-content-type-options": "nosniff",
      "x-frame-options": "ALLOW-FROM https://www.google.com https://app.chatwoot.com https://risk.clearbit.com",
      "x-xss-protection": "1; mode=block"
    },
    "config": {
      "transitional": {
        "silentJSONParsing": true,
        "forcedJSONParsing": true,
        "clarifyTimeoutError": false
      },
      "transformRequest": [
        null
      ],
      "transformResponse": [
        null
      ],
      "timeout": 0,
      "xsrfCookieName": "XSRF-TOKEN",
      "xsrfHeaderName": "X-XSRF-TOKEN",
      "maxContentLength": -1,
      "maxBodyLength": -1,
      "headers": {
        "Accept": "application/json, text/plain, */*",
        "Content-Type": "application/json",
        "Authorization": "Bearer eyJhbGciOiJSUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICJPLVEzMjdVSXlRdzAwbzY0NVRQWlNrSHpXY3N3cllmcl9Hdk9pcm9fWFc4In0.eyJleHAiOjE2NjUyMjg5NTgsImlhdCI6MTY2NTIyODA1OCwiYXV0aF90aW1lIjoxNjY1MjI4MDA1LCJqdGkiOiI2YTNjNTJiOC1mODFjLTRiMTktOTE4My1iNDczZWEzNjViYjAiLCJpc3MiOiJodHRwczovL2FwcC5waGFzZXR3by5pby9hdXRoL3JlYWxtcy9zZWxmIiwiYXVkIjpbInJlYWxtLW1hbmFnZW1lbnQiLCJicm9rZXIiLCJhY2NvdW50Il0sInN1YiI6ImM5Y2JlYmZiLWQxZTctNGY3Yy1hZDUyLTQyOTg1MmFiNmRmOSIsInR5cCI6IkJlYXJlciIsImF6cCI6ImlkcC13aXphcmQiLCJub25jZSI6IjViYWJhMjE4LThhY2MtNDk0Mi04Mjk2LTM1ZDZkZDMzYjEyOCIsInNlc3Npb25fc3RhdGUiOiJmMTdmM2M0Zi1jMDg4LTRkODctYjFlMS1jODNkNDc2N2MyY2QiLCJhbGxvd2VkLW9yaWdpbnMiOlsiLyoiXSwicmVhbG1fYWNjZXNzIjp7InJvbGVzIjpbImRlZmF1bHQtcm9sZXMtc2VsZiIsIm9mZmxpbmVfYWNjZXNzIiwidW1hX2F1dGhvcml6YXRpb24iXX0sInJlc291cmNlX2FjY2VzcyI6eyJyZWFsbS1tYW5hZ2VtZW50Ijp7InJvbGVzIjpbImNyZWF0ZS1vcmdhbml6YXRpb24iXX0sImJyb2tlciI6eyJyb2xlcyI6WyJyZWFkLXRva2VuIl19LCJhY2NvdW50Ijp7InJvbGVzIjpbIm1hbmFnZS1hY2NvdW50IiwibWFuYWdlLWFjY291bnQtbGlua3MiLCJ2aWV3LXByb2ZpbGUiXX19LCJzY29wZSI6Im9wZW5pZCBwcm9maWxlIGVtYWlsIiwic2lkIjoiZjE3ZjNjNGYtYzA4OC00ZDg3LWIxZTEtYzgzZDQ3NjdjMmNkIiwiZW1haWxfdmVyaWZpZWQiOnRydWUsIm9yZ19pZCI6ImI5MTQ1ZjU0LTI5ZTItNDAyNy05OTJmLTRkZDI3ZTIwYmUyOCIsIm9yZ2FuaXphdGlvbnMiOnsiYjkxNDVmNTQtMjllMi00MDI3LTk5MmYtNGRkMjdlMjBiZTI4Ijp7InJvbGVzIjpbIm1hbmFnZS1vcmdhbml6YXRpb24iLCJ2aWV3LXJvbGVzIiwibWFuYWdlLXJvbGVzIiwidmlldy1pZGVudGl0eS1wcm92aWRlcnMiLCJ2aWV3LW9yZ2FuaXphdGlvbiIsIm1hbmFnZS1pbnZpdGF0aW9ucyIsInZpZXctaW52aXRhdGlvbnMiLCJ2aWV3LW1lbWJlcnMiLCJtYW5hZ2UtaWRlbnRpdHktcHJvdmlkZXJzIiwibWFuYWdlLW1lbWJlcnMiXSwibmFtZSI6Im9yZy01cG9hbncweTFiIn0sIjgzOGMwOWI3LWUzM2EtNDNjOC1iOWE4LWIyYTg3YWQ3NGE2MiI6eyJyb2xlcyI6W10sIm5hbWUiOiJvcmctZTJyODR5ODRpcyJ9fSwibmFtZSI6IkdhcnRoIiwicHJlZmVycmVkX3VzZXJuYW1lIjoiZ2FydGhAdHVubmVsMTkuY29tIiwiZ2l2ZW5fbmFtZSI6IkdhcnRoIiwiZW1haWwiOiJnYXJ0aEB0dW5uZWwxOS5jb20ifQ.e-Zkz7KzFyHilOWkpvCjO7txPi6o861P6SZKHe8GIF_VZCmD6qcpQLnyjERdRpGjXaNVoZcCr3wD2pP-kO2RBwA0E1ZEVGuMhWAqFI16u7mf2P4Wf9ACT_Ngbj7BMPXMw_t5E7ZhkCTXjn2gLWxyYNF_OFkDwCtyoPuqerOMhz1aDWV9WXeO6piWlHb8GeGBlpeGg0Z7zUl7tMyPDKGxhaWZqZiL82xW2mNqsHAZJUtiIC9NIAgvj1dn2EErI1c5cu6TdnWcM-OIwiqHWxBCGkAW4jQByn-A0DTeLq15v4bqltKSHU7afYhNyhmEpf-I2h8AaxGWuHw1b_EtzNvA6Q"
      },
      "method": "post",
      "url": "https://app.phasetwo.io/auth/realms/self/orgs/b9145f54-29e2-4027-992f-4dd27e20be28/idps/import-config",
      "data": "{\"fromUrl\":\"https://portal.sso.us-west-2.amazonaws.com/saml/metadata/NzczNTMyNjQwNjM2X2lucy0yMDk3ZjdiYmM3NzVjMDg0\",\"providerId\":\"saml\",\"realm\":\"self\"}"
    },
    "request": {}
  }
}
xgp commented 1 year ago

Also effects OIDC clients in addition to SAML, whenever they use the import-config method.

xgp commented 1 year ago

https://github.com/p2-inc/idp-wizard/commit/0772a099862aef78e562403fba83bf0055c63e01

went from using the method in the client to not, which used to return the data directly