Finish up SAML generic wizard

p2-inc / idp-wizard

Identity Provider setup wizards for Keycloak

https://phasetwo.io

Other

5 stars 1 forks source link

Finish up SAML generic wizard #25

Closed jeffpatzer closed 2 years ago

jeffpatzer commented 2 years ago

Finishes form validations
Adds in success and failure states

For the "config" form, I wasn't able to figure out the right combo or data submission. See screenshots Sends back a 500,

with {"error":"unknown_error"} as the body to that response.

Side note - the Forms should be reusable for the other generics and guides which should speed building them up considerably.

xgp commented 2 years ago

On Step 2. Once one of the first two sections is validated, it correctly greys out and disables the "Validate" button, but should also grey out and disable the file selector "Select" button.

xgp commented 2 years ago

The title of step 4 is "Step 4: Create Enterprise Application". It should be "Step 4: Configure User Access".

xgp commented 2 years ago

For the config form (third section) in Step 2, there is no way (currently) to validate these input values. Just accept them and allow submission if they are both filled out.

xgp commented 2 years ago

Only the above comments @jeffpatzer . Otherwise the code LGTM.

jeffpatzer commented 2 years ago

@xgp got it, ill have those fixed shortly

jeffpatzer commented 2 years ago

Disable all inputs when one has become validated

Fixed title.

For form 2 in step 2, I'm not too concerned about the validation piece (just checking for presence). But when submitting those to the server, I was getting a 500 back. Not sure that's intended? Or if I'm not submitting correct values? Just wasn't getting back a metadata object and wanted to be certain that was as expected?