search

p2-inc / keycloak-events

Useful Keycloak event listener implementations and utilities.
https://phasetwo.io
Other
168 stars 35 forks source link

add primary key to WEBHOOK_EVENT_TYPES table #54

Closed hexiaodai closed 1 week ago

hexiaodai commented 4 months ago

The MySQL Mgr cluster requires that a unique primary key must exist in the table. Can a primary key be added when the table is initialized and created by keycloak?

hexiaodai commented 4 months ago

@xgp

xgp commented 4 months ago

@hexiaodai I don't see a problem with this. We'll need to run some regression tests on the other databases before we merge.

yitingdc commented 4 months ago

@xgp What is the progress about the regression tests? We also use MySQL Mgr cluster, and need this very much, when will we merge it? thx very much

xgp commented 4 months ago

We’ll work on it this in the next few weeks. If you have the time and it is urgent for you, please test against all the databases supported by Keycloak, and report your findings.

Because you need it very much does not eliminate the need to test against regression for all other users.

On Mon, Apr 22, 2024, at 10:27 AM, yitingdc wrote:

What is the progress about the regression tests? We also use MySQL Mgr cluster, and need this very much, shall we merge it asap? thx very much

— Reply to this email directly, view it on GitHub https://github.com/p2-inc/keycloak-events/pull/54#issuecomment-2068796101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3UHPQ2JC6N6NTPXH6J2TY6TCWJAVCNFSM6AAAAABGK4EHRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYG44TMMJQGE. You are receiving this because you were mentioned.Message ID: @.***>

xgp commented 1 week ago

Closing pending testing/validation by author.