search

p2-inc / keycloak-magic-link

Magic Link Authentication for Keycloak
Other
217 stars 43 forks source link

Updated to keycloak 24 #70

Closed redabourial closed 3 months ago

redabourial commented 4 months ago

updated the dep to keycloak 24 and updated depreciated/moved code

redabourial commented 4 months ago

I also found a bug that make magic links do not behave the same way when you run with --dev or prod. In dev the issuer will be the request's host header, while on prod it will be --hostname-url. it is a deal breaker for my use case. What are your thoughts on this ? Please see commit 6fe08f9 for a fix.

@xgp Should i revert the changes and open a new PR for this bugfix or just leave it as is ?

xgp commented 4 months ago

Please remove this and make a separate PR. I’ll need to review/understand this separately to see if we can make the change.

redabourial commented 4 months ago

Done https://github.com/p2-inc/keycloak-magic-link/pull/71