p2-inc / keycloak-magic-link

Magic Link Authentication for Keycloak
https://phasetwo.io
Other
245 stars 50 forks source link

action token is broken when frontendUrl is set #71

Closed redabourial closed 8 months ago

redabourial commented 8 months ago

I found a bug that make magic links do not behave the same way when you run with --dev or prod. In dev the issuer will be the request's host header, while on prod it will be --hostname-url. Please see commit 6fe08f9 for a fix.

xgp commented 8 months ago

@redabourial would you mind also filing a bug with a complete description of how to reproduce the bug? I don't understand based on "magic links do not behave the same way when you run with --dev or prod".

redabourial commented 8 months ago

@xgp done https://github.com/p2-inc/keycloak-magic-link/issues/72

redabourial commented 8 months ago

Will not be fixed