p2-inc / keycloak-magic-link

Magic Link Authentication for Keycloak
https://phasetwo.io
Other
231 stars 46 forks source link

Enhancement - Request to add username attribute to the token #76

Closed abhinavreddy9 closed 4 months ago

xgp commented 4 months ago

I don't see the argument for this. The action token is for the action token handler to determine the user. The username is not necessary for that.

abhinavreddy9 commented 4 months ago

Thanks for the clarification. I am relatively new to this and would appreciate if you can help me understand and make this change as custom implementation for my project.

Thanks in advance.

xgp commented 4 months ago

This is a feature request that is out of scope of this project. And no, I don't do free consulting. I will restate more severely what I implied before. If you're trying to use the token generated for the magic link for anything but the action token handler, you're doing it wrong and you should figure out another solution to your use case.

abhinavreddy9 commented 4 months ago

I understand. Appreciate your valuable time. Thank you!