search

p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
https://phasetwo.io
Other
389 stars 66 forks source link

Keycloak 19.0.1 #12

Closed MashB closed 1 year ago

MashB commented 1 year ago

Trying to setup extension for Keycloak 19.0.1

Please correct me if upgrading extension repo keycloak version to 19.0.1 is valid upgrade , since I have keycloak 19.0.1 setup. How do we resolve above issues considering migration to 19.0.1

Thanks

xgp commented 1 year ago

We're working on the upgrade to 19.0.1. Take a look in the testcontainers branch for the current state.

hookenful commented 1 year ago

Hello, can you please elaborate with actual state for 19.0.1 upgrade?

xgp commented 1 year ago

The extension as-is works with Keycloak 19.x. You don’t need to compile against the current version.

On Tue, Sep 27, 2022, at 8:45 AM, Vladislav wrote:

Hello, can you please elaborate with actual state for 19.0.1 upgrade?

— Reply to this email directly, view it on GitHub https://github.com/p2-inc/keycloak-orgs/issues/12#issuecomment-1259056155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3UHJIH24LGXPEF2G7GTDWAKJXBANCNFSM57LDTRFQ. You are receiving this because you commented.Message ID: @.***>

hookenful commented 1 year ago

The extension as-is works with Keycloak 19.x. You don’t need to compile against the current version. … On Tue, Sep 27, 2022, at 8:45 AM, Vladislav wrote: Hello, can you please elaborate with actual state for 19.0.1 upgrade? — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3UHJIH24LGXPEF2G7GTDWAKJXBANCNFSM57LDTRFQ. You are receiving this because you commented.Message ID: @.***>

Thanks, then I suppose OP's problem was resolved after 19.0.2 upgrade ?

xgp commented 1 year ago

What is "OP"?

hookenful commented 1 year ago

What is "OP"?

I meant "original poster".

hookenful commented 1 year ago

The extension as-is works with Keycloak 19.x.

During keycloak-orgs build, getting test run failed. I am doing by that instructions: https://github.com/p2-inc/keycloak-orgs#building

Have only changes in pom.xml with keycloak version bump image

Error logs: https://pastebin.com/4J35M4Y6

xgp commented 1 year ago

Sorry I was unclear. The build doesn’t work with the Keycloak version in the pom changed from 18. However, if you run the build as-is, the resulting jar will work in Keycloak 19.x.

xgp commented 1 year ago

Closing this for now, as the current version will run in 19.x, and I haven't been able to get testcontainers working properly. If the jar compiled against 18.x starts failing with subsequent versions of Keycloak, I'll revisit it.

hookenful commented 1 year ago

@xgp What was the main purpose for testcontainers branch?

xgp commented 1 year ago

The way we do testing with the org.keycloak.testsuite.KeycloakServer class relies on a library that is unreleased by the Keycloak team. Therefore, anyone who wants to compile this library themselves needs to compile Keycloak. When I tried to upgrade to Keycloak 19.x, my method stopped working.

I tried to update the tests using the testcontainers approach, but I encountered lots of problems importing my extension into the Keycloak container. You can find more detail on the issues here: https://github.com/dasniko/testcontainers-keycloak/issues/82

So, until we're able to resolve that problem, we can't upgrade the compile dependency.