search

p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
https://phasetwo.io
Other
405 stars 71 forks source link

Upgrade the forked Home IdP extension to latest commit #121

Closed phamann closed 1 year ago

phamann commented 1 year ago

TL;DR

Upgrades the forked version of https://github.com/sventorben/keycloak-home-idp-discovery embded within the projects source to the latest commit and then re-applies the nesscary keycloak-orgs patches ontop.

The main driving factor is to pickup improvements in the extension since we forked and take advantge of new configuration parameters.

Notes for reviewers

To help with the review I've isolated the custom p2-inc/keycloak-org changes to the extension in the second commit https://github.com/p2-inc/keycloak-orgs/commit/323cb0607113d4e2209caf69c642d65a2a60a4d2 4cb622f9a16487c8718f521c1774ef304ef23a5f

closes #83

phamann commented 1 year ago

I've just realised I didn't check to see if there was a diff in any of the template resources or messages. Will try push an update today.

phamann commented 1 year ago

Have now, pushed template changes 👍🏻

xgp commented 1 year ago

@phamann Everything looks good. I'd eventually like to figure out a way to test this, but I don't yet have a good way of testing frontend flows like this. I ran some manual tests on the branch locally, and I see no regressions.

phamann commented 1 year ago

@xgp sorry for the delay here. I've now fixed the AutoService annotation.