search

p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
Other
362 stars 65 forks source link

test: keycloak-orgs tests using testcontainers #130

Closed ngaxavi closed 8 months ago

ngaxavi commented 8 months ago

I have completed tests for all resources. I added a test for the organization mapper, and I will add tests for authentication in another branch later.

xgp commented 8 months ago

@ngaxavi Please remove all of the changes to imports and formatting. It makes the PR impossible to review.

ngaxavi commented 8 months ago

done

ngaxavi commented 8 months ago

@xgp any updates? I want to provide tests for the authentication, but I am waiting for this PR to merge

xgp commented 8 months ago

@ngaxavi Yes. Sorry for the delay. Everything is looking good. In the code where you've commented out the "teams" stuff, please go ahead and remove that altogether. Also, please bump the keycloak version to 22.0.5. Then I'll merge. Thanks again!

ngaxavi commented 8 months ago

@xgp I have made the changes. Instead of deleting all 'teams' stuff, I have just ignored the field "teams" in the Invitation class. I can well imagine that as a future feature, a group of people might be invited to another organization, like a bulk invitation.

xgp commented 8 months ago

Not sure what's going on (no logs), but the action that should be running the tests and releasing has been sitting for half an hour https://github.com/p2-inc/keycloak-orgs/actions/runs/6817068409/job/18539766715 image