p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
https://phasetwo.io
Other
417 stars 72 forks source link

Clean up representations #175

Closed xgp closed 9 months ago

xgp commented 9 months ago
MGLL commented 9 months ago

Does snake_case reference is for @JsonProperty("") annotations?

For example:

  @JsonProperty("domain_name")
  @NotNull
  public String getDomainName() {
    return domainName;
  }
xgp commented 9 months ago

Yes. This ticket is a cleanup issue.

  1. We shouldn't be hand coding these.
  2. We should make sure we update all objects received / returned by the API use snake_case (but also doesn't break backwards compatibility. This has been inconsistent, and it is frustrating to those hand-coding clients and not using the API libs or openapi.yaml

Not really a rush, but we'll probably get to it this quarter.