Invitations: Deletion of an inviter breaks GET /invitations endpoint

[MorryGun]

Steps to reproduce:

1. Create an invitation to Organization A with a custom inviter (User B)
2. Delete User B
3. Request invitations for Organization A

Expected result: 200 with a list of existing invitations Actual result: 400 with message {"error":"unknown_error"}

[xgp]

@MorryGun Good catch. It's failing because it can no longer look up the inviter by the stored ID.

We could either lazy remove these invites on load, or proactively on a UserModel.UserRemovedEvent event.

Care to PR a fix?

[MorryGun]

I don't think deleting invited is safe, I'd rather delete the inviter ID - as long as an email is sent, it is not needed anymore? BTW, if this is the case, what is the point of storing it in a DB?

[xgp]

The problem is that if the authority to make an invitation rested in a User that no longer exists, we should probably delete the invite.

BTW, if this is the case, what is the point of storing it in a DB?

It's returned in the API, so we can't break backwards compatibility. We, for one, use the inviter in our UI to show if you (or who) created the invitation.

[xgp]

Settled on lazy removing the inviterId. We may add removal of invites in the future.