p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
https://phasetwo.io
Other
418 stars 72 forks source link

Identity Providers tab in orgs admin UI performance issues #198

Closed xgp closed 7 months ago

xgp commented 8 months ago
xgp commented 8 months ago

Clarification: The bug here is that we don't even show the selected IdP when it's not in the first "page", because we currently show the active one by matching against the list. So let's prioritize updating to use the orgs idps endpoint, and then we can figure out how to deal with paging afterwards.

xgp commented 8 months ago

@pnzrr We should work off the 23.0.1_orgs_admin_ui branch for this, and then port any changes into the 24 branch currently underway.

xgp commented 8 months ago

@pnzrr We should also discuss how we want the update logic to work, and make sure we're implementing it correctly from the UI. See https://github.com/p2-inc/keycloak-orgs/issues/174#issuecomment-1948699543

pnzrr commented 8 months ago

https://www.keycloak.org/docs-api/24.0.1/rest-api/index.html#_get_adminrealmsrealmidentity_providerinstances

pnzrr commented 8 months ago

First priority: And for displaying the currently active one, we should update to use /realms/{realm}/orgs/{orgId}/idps

pnzrr commented 8 months ago

Priority 1: https://github.com/p2-inc/keycloak/pull/242

pnzrr commented 8 months ago

Priority 2: https://github.com/p2-inc/keycloak/pull/243

pnzrr commented 8 months ago
pnzrr commented 8 months ago

https://github.com/p2-inc/keycloak-orgs/pull/206

pnzrr commented 8 months ago

Updated https://github.com/p2-inc/keycloak/pull/244