p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
https://phasetwo.io
Other
389 stars 66 forks source link

Can't update the name of an OrganizationRole #58

Closed James-Ronayne closed 1 year ago

James-Ronayne commented 1 year ago

At the moment the PUT endpoint for role organisations only allows you to update the the roles description. Is there a reason that updating the role name is not supported?

xgp commented 1 year ago

@James-Ronayne thanks for raising this. Because of the way that we have implemented roles, there are relationships elsewhere that are based on the name. Because of that, it needs to be immutable once created. For the case where you want to change the role name, we recommend creating a new role with that name, and then adding members to that new role before removing them from the old role (which you can then delete).

James-Ronayne commented 1 year ago

Thanks for the speedy reply @xgp! That makes sense if there are other relationships elsewhere. I just saw it had a unique id column so assumed it would try to use the id for those relationships elsewhere, makes sense if not. It's a shame as I have a use case where the role name can change but the user assignments wouldn't.

If that's the only way to do the rename at the moment it's not the end of the world just a bit suboptimal. While I've got your attention the change your discussing here would be a great addition to see as well https://github.com/p2-inc/keycloak-orgs/issues/48 😄

xgp commented 1 year ago

Thanks @James-Ronayne. I'll close this one out, but we'll also take a look at potentially adding it when we do #48, which looks like will happen in the near future.