search

p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
Other
367 stars 65 forks source link

Feature request: endpoints for invitations #90

Closed matheushent closed 4 months ago

matheushent commented 1 year ago

Hi.

This is an issue to request essentially two endpoints related to invitations:

  1. GET {realm}/orgs/{orgId}/invitations/{invitationId}
  2. GET {realm}/orgs/{orgId}/invitations/count

As it is trivial to notice, [1] would fetch a single invite by its ID and potentially return 404 in case it doesn't exist. Similarly to GET {realm}/orgs/{orgId}/members/count, [2] is an endpoint to return the number of existing invites.

The addition of these two endpoints would enable a more powerful pagination in any backend that depends on querying the invites.

In advance, thank you!

xgp commented 1 year ago

@matheushent thank you for the suggestion. We have received a lot of feature requests to add counting and pagination to the list methods. It sounds like this is being used for larger volumes than we originally expected (which is great!). However, we're focused on some other tasks right now, so we can't prioritize this right away. Feel free to file a PR if you can do it.

xgp commented 5 months ago

GET {realm}/orgs/{orgId}/invitations/{invitationId} is getting done via https://github.com/p2-inc/keycloak-orgs/issues/151

matheushent commented 5 months ago

That is amazing. Thank you for that implementation!!