p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
Other
367 stars 65 forks source link

Add the ability to search for organizations by their attributes #93

Closed phamann closed 1 year ago

phamann commented 1 year ago

TL;DR

Following on from discussion in #88, this adds the ability to search for organizations based on their key=value attribute pairs, using a new q query paramter on the search resource, i.e GET /:realm/orgs?q=foo:bar.

Notes:


Closes #88

xgp commented 1 year ago

@phamann Thanks so much for this addition.

Regarding your tests question, this isn't a problem, as the phasetwo-java lib isn't updated until after we make API changes. However, it (and the other API client libs) gets generated based on a spec file here: https://github.com/p2-inc/phasetwo-docs/blob/master/openapi.yaml . Would you mind doing a PR for that spec file for the change you made?

phamann commented 1 year ago

Hey @xgp, I've now submitted a PR to also update the OpenAPI schema as requested. https://github.com/p2-inc/phasetwo-docs/pull/94

paulwer commented 1 year ago

@xgp when did you plan to release this in the docker oss environment / the client sdk?

xgp commented 1 year ago
paulwer commented 1 year ago

@xgp i didnt see any updates at keycloak-js did I miss something? or is this still pending?

xgp commented 1 year ago

Sorry, the java client went out. js client still pending.

xgp commented 1 year ago

@paulwer these are released.