search

p2-inc / keycloak-orgs

Single realm, multi-tenancy for SaaS apps
Other
367 stars 65 forks source link

refactor org search #95

Closed xgp closed 1 year ago

xgp commented 1 year ago

updated how org search works. refactored to simplify to one method in provider.

deprecated other get/search stream methods.

xgp commented 1 year ago

@phamann Please take a look if you have a moment. I updated some of your predicate code in the OrganizationProvider as well as simplified the interface there (+deprecated a few methods). Would be great to have your eyes/feedback!

We also discovered (independently of your earlier update) some problems with fetching and paginating results when the /orgs query was coming from an org member user, rather than a user with view-organizations role that was also fixed by moving the logic up into the query criteria.

xgp commented 1 year ago

@phamann thanks for taking the time to look. Really appreciate it!