search

p2-inc / keycloak-themes

Themes and theme utilities meant for simple theme customization without deploying a packaged theme
https://phasetwo.io
Other
28 stars 11 forks source link

/auth/ should not be hardcoded #1

Closed ser closed 1 year ago

ser commented 1 year ago

https://github.com/p2-inc/keycloak-themes/blob/6b57580acef0b32a515b37245b10d8f44fe855fa/src/main/resources/theme/attributes/login/template.ftl#L16

/auth/ should definitely NOT be hardcoded

xgp commented 1 year ago

Good catch. Happy to receive PRs.

ser commented 1 year ago

When I start keycloak I can see:

2022-12-02 07:49:15,417 INFO  [org.keycloak.quarkus.runtime.hostname.DefaultHostnameProvider] (main) Hostname settings: Base URL: <unset>, Hostname: example.com, Strict HTTPS: true, Path: <request>, Strict BackChannel: false, Admin URL: <unset>, Admin: admin.example.com, Port: -1, Proxied: true

I bet we should use Base URL