search

p2-inc / keycloak-themes

Themes and theme utilities meant for simple theme customization without deploying a packaged theme
https://phasetwo.io
Other
28 stars 11 forks source link

Fixes #21 - delete tmp folder on close #22

Closed gringostar closed 5 months ago

gringostar commented 6 months ago

After testing locally, I realised the proposed change does not fix the issue. The temp directory is only used to provide a path, so I have updated the PR to create the temp directory for the realm when needed, rather than with the creation of each instance.

xgp commented 6 months ago

Thanks @gringostar Is there a concurrency issue with this? If multiple sessions are using the same directory, isn't there a problem with concurrent writers? I originally went for directory per session to sidestep any concurrency problems.