Profile doesn't show email when "email as username" set. API broken.

[xgp]

Email doesn't get set when "email as username" is used. This appears to be a problem with the user account API

As a workaround, maybe we should look in the username for a valid email if an email field is not present.

[xgp]

Look at https://github.com/p2-inc/phasetwo-admin-portal/issues/81 in conjunction with fixing this.

[pnzrr]

featureFlags.registrationEmailAsUsername we're using this to decide whether or not to show the "username" right now, but I don't think that logic is right then.

{!featureFlags.registrationEmailAsUsername && (
            <RHFFormTextInputWithLabel
              slug="username"
              label={t("username")}
              register={register}
              registerArgs={{
                required: true,
                pattern: /\S+@\S+\.\S+/,
              }}
              inputArgs={{
                disabled: isLoadingAccount || !featureFlags.editUsernameAllowed,
                placeholder: "you",
                type: "username",
              }}
              error={errors.username}
            />
          )}
          <RHFFormTextInputWithLabel
            slug="email"
            label={t("email")}
            register={register}
            registerArgs={{
              required: true,
              pattern: /\S+@\S+\.\S+/,
            }}
            inputArgs={{
              disabled:
                isLoadingAccount || !featureFlags.updateEmailFeatureEnabled,
              placeholder: "your@email.com",
              type: "email",
            }}
            error={errors.email}
          />

I think the logic needs to be

• If the registrationEmailAsUsername is true, show a "Username / Email" form field. Only update the "username" though in this case. I think trying to set the email field when registrationEmailAsUsername might cause drift between username and email and you want them to stay in lockstep. I did this, the form validates (in browser) for a valid email.

• I think your suggestion of checking for a valid email in the username is unnecessary if that's already being set by the system? Or by allowing update of the username attribute, could that force not allowing a valid email? Which would mean we need the form to do that validity checking?
• If registrationEmailAsUsername is false, then show both username and email fields. Can we be sure username is set at this point? Should the form require it?