p2-inc / phasetwo-admin-portal

Other
18 stars 14 forks source link

Some colors not controlled by "Styles" settings #124

Closed awoimbee closed 6 months ago

awoimbee commented 6 months ago

Hi, I made an absolutely stunning color palette: stunning color palette

But sadly I still see a lot of default blue in the portal: portal still in blue

I noticed I could fix the issue using this CSS snippet:

.border-primary-700 {
  border-color: #04e300 !important;
}
.border-primary-700:hover {
  border-color: #027300 !important;
}
* {
  --tw-gradient-to: #04e300 !important;
  --tw-gradient-from: #027300 !important;
}

But there is still one hardcoded color: https://github.com/p2-inc/phasetwo-admin-portal/blob/4bb536ba0f2fe9392b03a791bcf271589a8f4f51/src/index.css#L15C18-L15C25

xgp commented 6 months ago

cc @pnzrr

pnzrr commented 6 months ago

hi @awoimbee thanks for reporting, i've got a draft PR in progress that is adding a lot more control over the UI for this.

you shouldn't need the !important on anything as all styles are injected last on the page

also applying a global style like that to the css var could create unexpected results. in the pr i inject styles as necessary for buttons and other elements. take a look there to see if that's getting close

i'm still testing the PR

pnzrr commented 6 months ago

@awoimbee just pushed an update through