p2-inc / phasetwo-admin-portal

https://phasetwo.io
Other
19 stars 14 forks source link

Invitations: ability to configure redirectUri #137

Open awoimbee opened 7 months ago

awoimbee commented 7 months ago

The invitation API allows requests without a redirectUri, but the default email template is broken: To accept or reject this invitation, click on the link below to log in. but there is no link.

It seems to me like:

This change is necessary for #136 as magic link requires a redirect_uri.

xgp commented 7 months ago

Thanks. We add the ability to set this value in our Admin UI, and it would also be useful in the Admin Portal.

We don't have a great solution to "always" setting the redirectUri. Most people just customize their email template with their app link. We can't now make it required, as that would break backwards compatibility. However, I like your idea of storing a default as an organization attribute. We'd take that PR in keycloak-orgs