p2-inc / phasetwo-admin-portal

https://phasetwo.io
Other
18 stars 14 forks source link

use UserProfileMetadata for profile #81

Open xgp opened 1 year ago

xgp commented 1 year ago

Personal information needs to come from / update UserProfileMetadata

xgp commented 1 year ago

See how they do it in the keycloak.v3 account theme https://github.com/keycloak/keycloak/tree/main/js/apps/account-ui/src/personal-info

pnzrr commented 1 year ago

Already pulling in with userProfileMetadata

image

so this isn't the issue. It's more as mentioned in #103 about how the data is picked for that particular profile.

@xgp seems like we could close this issue in lieu of 103 "fixing"

pnzrr commented 1 year ago

Also updating the account doesn't require the query param based on looking at the API spec. Should it?

MGLL commented 6 months ago

Does "help wanted" tag means you are looking for external / open-source support ? 😄

xgp commented 6 months ago

Yes!

pnzrr commented 2 months ago

@xgp to confirm, the idea is to change from explicitly only allowing username, email, first name, last name to allow editing anything in the UserProfileMetadata? This would match the User Details in the Admin UI?

image
xgp commented 2 months ago

Exactly.

This is to stay up to date with how Keycloak has moved from fixed properties to dynamic properties in UserProfileMetadata. Should be similar to how they do it in the account-v3 theme