p2-inc / phasetwo-admin-portal

https://phasetwo.io
Other
18 stars 14 forks source link

Clients names in device activity from messages.json #82

Open xgp opened 1 year ago

xgp commented 1 year ago

Clients name in device activity from messages.json (i think tomas removed the keys we weren’t using)

pnzrr commented 1 year ago

Looks more like the API returns empty for that value?

image

In that case it's using the clientId. Should it be a different use case?

image
xgp commented 1 year ago

There's supposed to be an internationalized message in the messages.json that can be looked up by the clientId key, but I think it got removed. I need to revisit how that file gets generated, as I think it should be a combination of static messages, and dynamic based on what is stored in Keycloak.