p2-inc / phasetwo-admin-portal

https://phasetwo.io
Other
18 stars 14 forks source link

fix: wrong url of css and scripts when opening portal in issue #89 #90

Closed cedric-beurtheret-jcd closed 1 year ago

cedric-beurtheret-jcd commented 1 year ago

In issue #87, modifying the config.ts file was not sufficient, and the problem was not solved, because of page generation through the template engine. So for issue #89, I had to change:

Then the base url is constructed at runtime by the PortalResourceProvider and injected in template.

xgp commented 1 year ago

@cedric-beurtheret-jcd thanks for the PR. Sorry I missed this, but I didn't have notifications for PRs setup right.