search

p2-inc / phasetwo-containers

Docker image for Phase Two Keycloak distribution
Other
66 stars 21 forks source link

24.0.3 image contains test dependencies in /opt/keycloak/providers #43

Closed zs-dahe closed 5 months ago

zs-dahe commented 5 months ago

Hi, it seems that the latest quay.io/phasetwo/phasetwo-keycloak:24.0.3 contains some test dependencies (testcontainers, hamcrest, etc.) in the /opt/keycloak/providers directory that weren't present before:

>  docker run -t --entrypoint /bin/sh quay.io/phasetwo/phasetwo-keycloak:24.0.2 -c "ls -l /opt/keycloak/providers"
total 27256
-rw-r--r-- 1 root     root   537729 Apr  4 19:17 dnsjava-dnsjava-3.5.3.jar
-rw-r--r-- 1 root     root   218968 Apr  4 19:17 io.phasetwo.keycloak-keycloak-events-0.27.jar
-rw-r--r-- 1 root     root    65352 Apr  4 19:17 io.phasetwo.keycloak-keycloak-magic-link-0.26.jar
-rw-r--r-- 1 root     root   292209 Apr  4 19:17 io.phasetwo.keycloak-keycloak-orgs-0.68.jar
-rw-r--r-- 1 root     root   179725 Apr  4 19:17 io.phasetwo.keycloak-keycloak-themes-0.25.jar
-rw-r--r-- 1 root     root  1247617 Apr  4 19:17 io.phasetwo-phasetwo-admin-portal-0.27.jar
-rw-r--r-- 1 root     root 15800712 Apr  4 19:17 io.phasetwo-phasetwo-idp-wizard-0.1.jar
-rw-r--r-- 1 root     root    27777 Apr  4 19:17 keycloak-rest-provider-2.0.0.jar
-rw-r--r-- 1 root     root    47396 Apr  4 19:17 org.wildfly.client-wildfly-client-config-1.0.1.Final.jar
-rw-r--r-- 1 root     root  9471248 Apr  4 19:17 phasetwo-admin-ui-24.0.0.jar
-rw-rw-r-- 1 keycloak root      256 Jun 28  2023 README.md

> docker run -t --entrypoint /bin/sh quay.io/phasetwo/phasetwo-keycloak:24.0.3 -c "ls -l /opt/keycloak/providers"
total 52668
-rw-r--r-- 1 root     root    75717 Apr 24 18:43 com.fasterxml.jackson.core-jackson-annotations-2.13.4.jar
-rw-r--r-- 1 root     root   374895 Apr 24 18:43 com.fasterxml.jackson.core-jackson-core-2.13.4.jar
-rw-r--r-- 1 root     root  1531681 Apr 24 18:43 com.fasterxml.jackson.core-jackson-databind-2.13.4.2.jar
-rw-r--r-- 1 root     root   470861 Apr 24 18:43 com.github.docker-java-docker-java-api-3.3.3.jar
-rw-r--r-- 1 root     root    37598 Apr 24 18:43 com.github.docker-java-docker-java-transport-3.3.3.jar
-rw-r--r-- 1 root     root  2038549 Apr 24 18:43 com.github.docker-java-docker-java-transport-zerodep-3.3.3.jar
-rw-r--r-- 1 root     root    19936 Apr 24 18:43 com.google.code.findbugs-jsr305-3.0.2.jar
-rw-r--r-- 1 root     root   537729 Apr 24 18:43 dnsjava-dnsjava-3.5.3.jar
-rw-r--r-- 1 root     root    23491 Apr 24 18:43 io.github.wimdeblauwe-testcontainers-cypress-1.9.0.jar
-rw-r--r-- 1 root     root   219248 Apr 24 18:43 io.phasetwo.keycloak-keycloak-events-0.29.jar
-rw-r--r-- 1 root     root    65352 Apr 24 18:43 io.phasetwo.keycloak-keycloak-magic-link-0.26.jar
-rw-r--r-- 1 root     root   301514 Apr 24 18:43 io.phasetwo.keycloak-keycloak-orgs-0.70.jar
-rw-r--r-- 1 root     root   209926 Apr 24 18:43 io.phasetwo.keycloak-keycloak-themes-0.28.jar
-rw-r--r-- 1 root     root  1253542 Apr 24 18:43 io.phasetwo-phasetwo-admin-portal-0.28.jar
-rw-r--r-- 1 root     root 15800712 Apr 24 18:43 io.phasetwo-phasetwo-idp-wizard-0.1.jar
-rw-r--r-- 1 root     root   384581 Apr 24 18:43 junit-junit-4.13.2.jar
-rw-r--r-- 1 root     root    27775 Apr 24 18:42 keycloak-rest-provider-4.0.0.jar
-rw-r--r-- 1 root     root  1866196 Apr 24 18:43 net.java.dev.jna-jna-5.12.1.jar
-rw-r--r-- 1 root     root  1076223 Apr 24 18:43 org.apache.commons-commons-compress-1.24.0.jar
-rw-r--r-- 1 root     root   503880 Apr 24 18:43 org.apache.commons-commons-lang3-3.9.jar
-rw-r--r-- 1 root     root    45024 Apr 24 18:43 org.hamcrest-hamcrest-core-1.3.jar
-rw-r--r-- 1 root     root    19014 Apr 24 18:43 org.jetbrains-annotations-17.0.0.jar
-rw-r--r-- 1 root     root    25402 Apr 24 18:43 org.rnorth.duct-tape-duct-tape-1.0.8.jar
-rw-r--r-- 1 root     root    41125 Apr 24 18:43 org.slf4j-slf4j-api-1.7.36.jar
-rw-r--r-- 1 root     root 17407714 Apr 24 18:43 org.testcontainers-testcontainers-1.19.1.jar
-rw-r--r-- 1 root     root    47396 Apr 24 18:43 org.wildfly.client-wildfly-client-config-1.0.1.Final.jar
-rw-r--r-- 1 root     root  9474919 Apr 24 18:42 phasetwo-admin-ui-24.0.0.jar
-rw-rw-r-- 1 keycloak root      256 Jun 28  2023 README.md

Are these JARs actually used for anything when running keycloak in the container? If they are not needed, I assume it is safe to delete the additional files? In this case, would it be possible to remove them from the image in order to reduce the image size a bit?

xgp commented 5 months ago

@zs-dahe great catch! It looks like this is a function of a test dependency that wasn't properly scoped in the most recent release of keycloak-orgs. We'll release a fix to keycloak-orgs and then update this with a new image release. Thanks.

xgp commented 5 months ago

24.0.3.1714408083 should fix this.