search

p2 / OAuth2

OAuth2 framework for macOS and iOS, written in Swift.
Other
1.15k stars 277 forks source link

Fix exception on WKNavigationDelegate method #298

Closed xpablocx closed 5 years ago

xpablocx commented 5 years ago

Fix exception thrown on webView(_:decidePolicyforNavigationAction:decisionHandler:) due to double call to decisionHandler.

p2 commented 5 years ago

This was fixed in #227 already, are you running master or an older version?

xpablocx commented 5 years ago

My bad, I was using version 3.0.3. It is now indeed fixed in the latest version (4.0.1).

I carelessly copied the string from Readme.md to my Cartfile to install it with Carthage, assuming the latest version would be installed. That string reads github "p2/OAuth2" ~> 3.0, so version 3.0.3 was installed (same version is used in the CocoaPods instructions).

Maybe consider changing that string to version 4.0 to avoid silly errors like mine? (github "p2/OAuth2" ~> 4.0, unless is there is a reason why you're not updating it just yet).