Swift 4.2 updates - Githubissues

p2 / OAuth2

OAuth2 framework for macOS and iOS, written in Swift.

Other

1.15k stars 277 forks source link

Swift 4.2 updates #299

Closed cgossain closed 5 years ago

cgossain commented 5 years ago

Ran the Swift 4.2 migration on all targets, and updated @objc inference build setting to 'Default' on all targets.
Updated project to recommended settings.
Fixed all compiler warnings except for warning on line 30 in OAuth2AuthorizerUI.swift. The use of unowned should not be applied to a property declaration and will be removed in future versions. I did not make a change here as I don't know the potential ramifications of this.

p2 commented 5 years ago

This was already done in #273 , it appears the dev branch is behind.

cgossain commented 5 years ago

Ya I did notice the changes in #273, but for some reason when I pulled in the latest commit on the develop branch, I still ran into all this Xcode warnings and upgrade messages.

djbe commented 5 years ago

The required changes have been merged, so this PR is no longer necessary.

cgossain commented 5 years ago

Hi, I just tested and you’re correct. The pod version has been updated and it’s now working. I will close the PR.