p2 / OAuth2

OAuth2 framework for macOS and iOS, written in Swift.
Other
1.14k stars 278 forks source link

Update Swift package manager configuration #322

Closed drdavec closed 5 years ago

drdavec commented 5 years ago

Update Swift Package Manager (SPM) configuration tested with Xcode 11 beta 7, backward compatible to earlier Xcode versions.

Several functions changed to public visibility for compatibility with Swift-SMART using SPM dependencies instead of previous method of copying OAuth2 sources into that build.

Phase 2 of the SPM reconfiguration will be posted as additional PR, eliminating use of compiler directives #if !NO_MODULE_IMPORT, and using SPM to build a single OAuth2 package from all source folders.

ossus-lib commented 5 years ago

Thanks, looks good!

drdavec commented 5 years ago

Thanks for getting this committed! Can you add a Release for version 5.1.0? The swift packages manager requires released versions for dependencies. Could use a Tag, but I think that a versioned release would be preferable.

I have Swift-SMART updated and tested with SWM, will commit when I have the OAuth2 release for package dependency.

Thanks! Dave

On Wed, Sep 11, 2019 at 12:28 AM Ossus Library notifications@github.com wrote:

Merged #322 https://github.com/p2/OAuth2/pull/322 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/p2/OAuth2/pull/322?email_source=notifications&email_token=AKEBNHIQ43WQKPU32ETD6QDQJCFYTA5CNFSM4IUUDTSKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTRXX7XQ#event-2624552926, or mute the thread https://github.com/notifications/unsubscribe-auth/AKEBNHJS7W537LYU4DXXNRLQJCFYTANCNFSM4IUUDTSA .