Add refresh uri - Githubissues

p2 / OAuth2

OAuth2 framework for macOS and iOS, written in Swift.

Other

1.14k stars 278 forks source link

Add refresh uri #330

Closed fotiDim closed 4 years ago

fotiDim commented 4 years ago

I added a new token refresh URI which takes priority if it set over the token URI. My use case was for Spotify's auth code flow which suggests hosting your own token swap and token refresh endpoints. Sample implementation here

ossus-lib commented 4 years ago

Thanks! Some things:

can you document "refresh_uri" where "token_uri" is also mentioned?
change the unit tests to indent using tabs
add your name to CONTRIBUTORS

fotiDim commented 4 years ago

@ossus-lib please check now. I wasn't sure where you wanted the documentation exactly so I added a short paragraph in the readme.

ossus-lib commented 4 years ago

Good! Please can you also add them to OAuth2Base (line 158) and OAuth2 (line 60) in the comments to the init() methods? Thanks.

fotiDim commented 4 years ago

@ossus-lib right, I missed that. Done!