search

p2 / OAuth2

OAuth2 framework for macOS and iOS, written in Swift.
Other
1.14k stars 275 forks source link

fixed issue with wrong state-machine after pull down gesture on presented SFSafariViewController #396

Closed cbruns1985 closed 5 months ago

cbruns1985 commented 1 year ago

In case the SFSafariViewController is presented modally, it can be dismissed via pull down gesture. In that case the state machine is completely broken. Therefore I added the presentationDelegate, which ensures that the same logic is triggered as in case the "Finished" button is pressed with this interaction.

ossus-lib commented 5 months ago

I missed this, @cbruns1985 would you mind re-targeting this request to main so I can merge it?

cbruns1985 commented 5 months ago

@ossus-lib pretty difficult, due to my fork does not have the branches. Let me check how I can somehow make this happen ...

cbruns1985 commented 5 months ago

https://github.com/p2/OAuth2/pull/415 had to remove the branch and reopen another one with the correct bases from main. Find here a new PR.

Reopen does not work. Therefore a new PR @ossus-lib .