p2 / quicklook-csv

A QuickLook plugin for CSV files
Other
289 stars 22 forks source link

update version 1.4 to fix quote count exceptions #13

Closed othercat closed 11 years ago

othercat commented 11 years ago

add a test csv file which contains the error typo quote. should not be blocked displaying the rest formats.

p2 commented 11 years ago

The file testHeightError.csv displays fine for me with 1.3, do you have another example where 1.3 fails but your version does not?

othercat commented 11 years ago

sorry for the confusing content of the file testHeightError.csv. the correct content is

x,y,ex,ey
""1.1",1.2,1.3,1.4
2.1,2.2,2.3,2.4

There was one more quote mark before.

othercat commented 11 years ago

and here is another example of the exception.

x,y,ex,ey
""""1.1",1.2,1.3,1.4
2.1,2.2,2.3,2.4

even though it is indeed the error from csv format, the error from current row should not block the correct displaying of other rows.

p2 commented 11 years ago

The problem with your fix is that it breaks correct CSV that contains newlines in cells. Here's an example:

x,y,ex,ey
"1.1
newline",1.2,1.3,1.4
2.1,2.2,2.3,2.4
othercat commented 11 years ago

Okay... so what I did is just a workaound for the exceptions. But the background of the request is that some Windows software will generate this incorrect format.Let me think about it….

p2 commented 11 years ago

Ok, open a new issue/pull request if you find a solution, I'll close this for now.